Repository navigation
fix: count tool call arguments in the compaction tail budget - #258
Open
liuzhengyang699 wants to merge 1 commit into
Open
liuzhengyang699 wants to merge 1 commit into
liuzhengyang699 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compaction counts only message content when deciding which history fits in the retained tail. Assistant tool calls commonly have empty content but large arguments, so an old file-writing call can be retained as if it consumed no context.
Include the serialized tool calls in the character estimate, as the runtime token estimator already does. The current-user-turn retention rule and tool-call pairing still apply.
Validation: 9 tests passed across
tests/test_compaction_tool_call_budget.pyandtests/test_session_compaction.py. The new old-call regression fails before the fix; a second case verifies that a large call in the active turn keeps its matching tool result. Ruff 0.15.21 check/format andgit diff --checkpassed on the changed files.