Repository navigation
Precompile the first calls of a JuliaCall session - #837
Open
MilesCranmerBot wants to merge 1 commit into
Open
MilesCranmerBot wants to merge 1 commit into
MilesCranmerBot wants to merge 1 commit into
Conversation
A new JuliaCall session usually starts with `jl.<name>` on `juliacall.Main` or `jl.seval(...)`. PythonCall's package image had no compiled code for either method, so every session compiled them at runtime, which took about a second. Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Contributor
|
@cjdoris so this was a surprisingly decent improvement to startup time |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python reaches
pyjlany_getattrandpyjlmodule_sevalthrough_pyjl_callmethod, which looks them up inPYJLMETHODSat runtime. Precompiling PythonCall therefore never compiled them, and every new JuliaCall session compiled them on its firstjl.<name>orjl.seval(...). This PR adds aprecompilestatement for each.First call in a fresh Python process (median of 8, Apple M1 Pro,
PYTHON_JULIACALL_HANDLE_SIGNALS=yes):mainjl.VERSIONjl.seval("1 + 1")jl.VERSIONjl.seval("1 + 1")Julia tests pass locally on 1.11.9 (3517 passed, 3 broken).