Repository navigation
fix(startup): match preview and explorer loading states - #275
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On desktop startup, the editor showed loading bars while the preview displayed a separate search introduction and Explorer appeared empty. The preview now uses the same loading layout, spacing, colors, and animation as the editor from the first paint. Explorer shows indented workspace/file placeholders until its real tree is rendered.
The separate introduction is retained as a JavaScript-disabled fallback. The normal welcome document, translated starter documents, and saved files still load through the existing document flow. Desktop resources and the localization documentation are updated.
Validation:
npm test: build validation, 22 unit tests, and all 289 Chromium tests passed.node desktop-app/prepare.jsregenerated and validated the desktop resources.