Repository navigation
Conversation
C++ 5.3.0 fixes five deserialization vulnerabilities (CVE-2026-103501, -103513, -103634, -103635, -103636), which this package inherits. Two C++ member functions gained a defaulted parameter, which breaks the bindings that take their address: - update_theta_sketch::compact(ordered, trim): expose trim=False. Without a second nb::arg the build fails. - hll_sketch::reset(full_size): expose full_size=False. Without an nb::arg, reset() required an argument and test_hll_* failed. Also bind the new frequent_items_sketch::reset(). Adds tests for all three. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tisonkun
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the bundled C++ library from 5.2.0 to 5.3.0 (
GIT_TAGinCMakeLists.txt).C++ 5.3.0 fixes five vulnerabilities in sketch deserialization (CVE-2026-103501, CVE-2026-103513, CVE-2026-103634, CVE-2026-103635, CVE-2026-103636; see https://datasketches.apache.org/docs/Community/Security.html). The Python package compiles that C++ code in, so current datasketches-python releases are affected until a release built on 5.3.0 ships.
Binding changes required by 5.3.0
Two C++ member functions gained a defaulted parameter. Default arguments are not part of a member-function pointer, so the bindings that take their address broke:
update_theta_sketch::compact(ordered, trim)(Add optional trim flag to update_theta_sketch::compact() datasketches-cpp#524): the build failed with nanobind's "number of nb::arg annotations must match the argument count" assertion. The binding now exposescompact(ordered=True, trim=False);trim=Truereturns at most k entries.hll_sketch::reset(full_size)(Stop persisting the full-size flag in serialization flags bit 32 (0x20) datasketches-cpp#521): this compiled, butreset()with no argument raised aTypeError. The binding now exposesreset(full_size=False).Also
frequent_items_sketch::reset()(frequent_items_sketch: add reset(), decide emptiness by preamble longs datasketches-cpp#529) for both frequent items sketch types.compact(trim=True),reset(full_size=True)and the frequent itemsreset().Built locally on macOS with Python 3.12; all 37 tests pass.
🤖 Generated with Claude Code