Repository navigation
[CDTOOL-1744] CLI support for routing configs - #1931
Merged
Merged
Conversation
anthony-gomez-fastly
force-pushed
the
CDTOOL-1744-routing-configs
branch
3 times, most recently
from
October 7, 2026 17:48
56211f1 to
6aed881
Compare
Adds the `fastly routing-config` command family (create/describe/list/ delete/activate/deactivate, plus nested draft, version, path, and path rule subcommands) backed by the go-fastly domain-management routing-configs client. Also adds `--routing-config-id` / `--unset-routing-config-id` to `fastly domain update` to manage the domain-to-routing-config linkage, and documents all new commands
anthony-gomez-fastly
force-pushed
the
CDTOOL-1744-routing-configs
branch
from
October 7, 2026 19:23
6aed881 to
3db04e3
Compare
anthony-gomez-fastly
marked this pull request as ready for review
October 7, 2026 19:24
anthony-gomez-fastly
requested review from
jedisct1 and
kpfleming
and
a balanced review from Copilot
October 7, 2026 19:24
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
5 open findings
--routing-config-id/--unset-routing-config-id, but the… · New--routing-config-id/--unset-routing-config-id, but the… · New.String()in… · NewUpdatedAtappears to be a time-like value where.String()is… · New
What changed in this PR
Adds CLI support for Fastly Domain Management routing configs, including routing-config CRUD/subcommands and domain↔routing-config association management.
Changes:
- Introduces
fastly routing-configcommand family with nesteddraft,version,path, andpath rulesubcommands. - Extends
fastly domain updatewith--routing-config-idsupport and documents new behavior in metadata. - Registers new commands in the CLI command registry and updates changelog/app metadata.
| File | Description |
|---|---|
| pkg/commands/routingconfig/root.go | Adds routing-config command root. |
| pkg/commands/routingconfig/doc.go | Package docs for routing-config commands. |
| pkg/commands/routingconfig/create.go | Implements routing-config create. |
| pkg/commands/routingconfig/describe.go | Implements routing-config describe/get. |
| pkg/commands/routingconfig/list.go | Implements routing-config list with filtering/sorting. |
| pkg/commands/routingconfig/delete.go | Implements routing-config delete/remove (with --force). |
| pkg/commands/routingconfig/activate.go | Implements routing-config activate (activate draft). |
| pkg/commands/routingconfig/deactivate.go | Implements routing-config deactivate. |
| pkg/commands/routingconfig/common.go | Adds summary/verbose output helpers for routing configs. |
| pkg/commands/routingconfig/draft/root.go | Adds routing-config draft subcommand root. |
| pkg/commands/routingconfig/draft/doc.go | Package docs for draft subcommands. |
| pkg/commands/routingconfig/draft/diff.go | Implements routing-config draft diff. |
| pkg/commands/routingconfig/draft/update.go | Implements routing-config draft update (comment). |
| pkg/commands/routingconfig/draft/delete.go | Implements routing-config draft delete/discard. |
| pkg/commands/routingconfig/version/root.go | Adds routing-config version subcommand root. |
| pkg/commands/routingconfig/version/doc.go | Package docs for version subcommands. |
| pkg/commands/routingconfig/version/list.go | Implements routing-config version list. |
| pkg/commands/routingconfig/version/activate.go | Implements routing-config version activate (reactivate). |
| pkg/commands/routingconfig/version/deleteinactive.go | Implements routing-config version delete-inactive. |
| pkg/commands/routingconfig/path/root.go | Adds routing-config path subcommand root. |
| pkg/commands/routingconfig/path/doc.go | Package docs for path subcommands. |
| pkg/commands/routingconfig/path/create.go | Implements routing-config path create. |
| pkg/commands/routingconfig/path/describe.go | Implements routing-config path describe/get. |
| pkg/commands/routingconfig/path/list.go | Implements routing-config path list with filtering/sorting. |
| pkg/commands/routingconfig/path/update.go | Implements routing-config path update. |
| pkg/commands/routingconfig/path/delete.go | Implements routing-config path delete/remove. |
| pkg/commands/routingconfig/path/common.go | Adds summary/verbose output helpers for paths. |
| pkg/commands/routingconfig/path/rule/root.go | Adds routing-config path rule subcommand root. |
| pkg/commands/routingconfig/path/rule/doc.go | Package docs for rule subcommands. |
| pkg/commands/routingconfig/path/rule/create.go | Implements routing-config path rule create/add (JSON file input). |
| pkg/commands/routingconfig/path/rule/describe.go | Implements routing-config path rule describe/get. |
| pkg/commands/routingconfig/path/rule/list.go | Implements routing-config path rule list. |
| pkg/commands/routingconfig/path/rule/update.go | Implements routing-config path rule update (JSON file input). |
| pkg/commands/routingconfig/path/rule/delete.go | Implements routing-config path rule delete/remove. |
| pkg/commands/routingconfig/path/rule/common.go | Adds summary/verbose output helpers for rules. |
| pkg/commands/domain/update.go | Adds --routing-config-id support to domain update and prints association in success output. |
| pkg/commands/domain/domain_test.go | Adds test cases covering new domain update routing-config behavior. |
| pkg/commands/commands.go | Registers routing-config command tree in CLI. |
| pkg/app/run_test.go | Updates top-level command list test to include routing-config. |
| pkg/app/metadata.json | Documents new routing-config command examples and new domain update examples. |
| CHANGELOG.md | Adds changelog entry for routing-config CLI support. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
3 open findings
'nil'to mean “clear the association” can be ambiguous (it makes… · New'nil'to mean “clear the association” can be ambiguous (it makes… · NewJSON(capitalized) and could be made slightly more… · New
5 resolved since last review
UpdatedAtappears to be a time-like value where.String()is….String()in…--routing-config-id/--unset-routing-config-id, but the…--routing-config-id/--unset-routing-config-id, but the…
🧠 Review effort: Lite
kpfleming
requested changes
Oct 8, 2026
kpfleming
approved these changes
Oct 8, 2026
kpfleming
left a comment
kpfleming
left a comment
Member
There was a problem hiding this comment.
This looks good to me, other than the decision to use deploy or activate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Adds the
fastly routing-configcommand family (create/describe/list/ delete/activate/deactivate, plus nested draft, version, path, and path rule subcommands) backed by the go-fastly domain-management routing-configs client. Also adds--routing-config-idtofastly domain updateto manage the domain-to-routing-config linkage, and documents all new commandsAPI Spec
All Submissions:
New Feature Submissions: