Repository navigation
test: migrate stats/incr/covariance to ULP-based assertions - #16055
Merged
Merged
Conversation
Replaces relative tolerance assertions with `isAlmostSameValue` ULP difference assertions, using the minimum required ULP values. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A8ZXSNMg8YzKdWufa2d5kW
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/covariancefrom relative tolerance testing to ULP difference testing, replacing the computeddelta/tolcomparisons with@stdlib/assert/is-almost-same-value.the accumulator function incrementally computes an unbiased sample covariance: 4 ULP (tightened down from an initial bound of 64; the suite fails at 3 ULP, so 4 is the minimum)the accumulator function incrementally computes an unbiased sample covariance (known means): 0 ULP (every accumulated value matches the Julia fixture exactly)@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires and the associateddelta/toldeclarations.Consistent with the prior art in this family (e.g.
math/base/special/xlogy), the existingif ( actual === expected[ i ] )exact-equality branch is left in place and only theelsebranch is migrated. No fixtures, test names, or test cases were otherwise changed.Verification:
make test TESTS_FILTER=".*/stats/incr/covariance/.*"— 95 passing, 0 failing. Run twice at the final ULP values with identical results, confirming the bounds are not sensitive to FMA/architecture differences.make lint-javascript-tests TESTS_FILTER=".*/stats/incr/covariance/.*"— clean.lib/node_modules/@stdlib/stats/incr/covariance/test/test.js.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The second test block's assertion is exercised only through the exact-equality branch, so its
elsebranch is unreachable for the current fixture;0is recorded there as the tightest admissible bound rather than as a measured non-zero error.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written entirely by Claude Code, running unattended as a scheduled task. Claude selected the package, studied the already-converted packages in the repository to match the project's settled idiom, measured the minimum ULP bounds, applied the migration, and ran the tests and linters.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01A8ZXSNMg8YzKdWufa2d5kW
Generated by Claude Code